1. Einstein Toolkit Avatar Einstein Toolkit
  2. Einstein Toolkit
  3. tickets
  4. Issues

EOS_Omni: piecewise polytrope support with up to 10 pieces

Issue #2040 closed
Frank Löffler created an issue

The following pull-request should be looked at:

https://bitbucket.org/einsteintoolkit/einsteineos/pull-requests/2/modification-for-work-phys-rev-d93-064047/diff

As described there, this includes:

    Modification for work: Phys. Rev. D93, 064047 (2016), arXiv:1509.08804
    Now it support hybrid EOS with up to ten pieces
    Bug corrected on allocation of teh paramter set for back-compatibility
    EOS_Omni: remove space

Note that the diff as shown on butbucket is mis-leading. It mixes parameter names and values in ways that easily lead to misunderstandings.

Keyword: parma

Comments (9)

  4. Roland Haas
    • changed status to open
    • removed comment

    Comments are in the pull request. Basically: the code is fine, the physics as well (I had tested against another code and re-derived most of the expressions).

    I am not sure if it should go in right away as it is unclear how much of a speed impact (for example) the loops over pieces have and also for the fact that this is a backwards incompatible change very shortly before the release. It does seem to introduce a handful of changes of behaviour which should not go into the ET without testing first.

  10. Log in to comment
Assignee
–
Type
enhancement
Priority
minor
Status
closed
Component
EinsteinToolkit thorn
Milestone
–
Version
development version
Votes
0
Watchers
0
Jira Software: the preferred issue tracker for Bitbucket. Join the team!