Simfactory assumes python is python2

Comments (12)

1. 

   Ian Hinder

   • removed comment

   • 2017-08-04T12:11:02+00:00
2. 

   Steven R. Brandt reporter

   • removed comment

   Based on conversations and emails, I think this is what we want.

   diff --git a/bin/sim b/bin/sim
   index 92f74ab..c6bc075 100755
   --- a/bin/sim
   +++ b/bin/sim
   @@ -20,4 +20,18 @@ if [ -z "$cmd" ]; then
    fi
   
    # Forward the call
   -exec python "$cmd" "$@"
   +for PYEXE in python python2
   +do
   +    $PYEXE - > /dev/null 2>&1 << EOF
   +import sys
   +if sys.hexversion < 0x3000000:
   +    exit(0)
   +else:
   +    exit(1)
   +EOF
   +    if [ $? = 0 ]
   +    then
   +        exec $PYEXE "$cmd" "$@"
   +        break
   +    fi
   +done
   

   • 2017-08-04T13:30:30+00:00
3. 

   Erik Schnetter

   • removed comment

   This should check python2 first.

   • 2017-08-04T13:37:13+00:00
4. 

   Steven R. Brandt reporter

   • removed comment

   If I agree to make that change can you put it in review_ok?

   • 2017-08-04T14:02:10+00:00
5. 

   Roland Haas

   • removed comment

   Since we are version testing, it would also make sense to put in a minimal accepted version (likely python 2.6 or 2.7) I think. The "break" should likely be replaced by an "exit $?" since "exec" can return to its caller (eg if redirection fails, but not if it fails to execute the program).

   • 2017-08-06T15:11:11+00:00
6. 

   Steven R. Brandt reporter

   • removed comment

   I don't want to pick an arbitrary minimum version. If you know of a version for which Simfactory doesn't then I'm all for setting one, otherwise I'd rather not. Using exits make some sense. Anyway, here's what I currently suggest.

   # Forward the call
   for PYEXE in python2 python
   do
       $PYEXE - > /dev/null 2>&1 << EOF
   import sys
   if sys.hexversion < 0x3000000:
       exit(0)
   else:
       exit(1)
   EOF
       if [ $? = 0 ] 
       then
           exec $PYEXE "$cmd" "$@"
           exit 1
       fi  
   done
   exit 2
   

   • 2017-08-07T09:05:34+00:00
7. 

   Erik Schnetter

   • removed comment

   Simfactory requires Python 2.3, since that was installed on Queen Bee at the time it was developed, and Queen Bee (at that time) had one of the oldest Red Hat versions. We might have switched to Python 2.6 in the mean time, either accidentally or on purpose, but I'd go with 2.3.

   • 2017-08-07T09:07:20+00:00
8. 

   Steven R. Brandt reporter

   • removed comment

   OK, then. Version 2.3 corresponds to 0x2030000.

   # Forward the call
   for PYEXE in python2 python
   do
       $PYEXE - > /dev/null 2>&1 << EOF
   import sys
   if sys.hexversion >= 0x2030000 and sys.hexversion < 0x3000000:
       exit(0)
   else:
       exit(1)
   EOF
       if [ $? = 0 ] 
       then
           exec $PYEXE "$cmd" "$@"
           exit 1
       fi  
   done
   exit 2
   

   • 2017-08-07T09:11:45+00:00
9. 

   Roland Haas

   • changed status to open
   • removed comment

   Change to review state.

   • 2017-08-14T11:27:53+00:00
10. 

    Roland Haas

    • changed status to open
    • removed comment

    Looks ok. Please apply.

    • 2017-08-14T11:28:02+00:00
11. 

    Steven R. Brandt reporter

    • changed status to resolved
    • removed comment

    Fixed in commit 96d3250cc317cceb179b9f4b6f69f9344802a6fd of https://bitbucket.org/simfactory/simfactory2.git

    • 2017-08-21T09:44:14+00:00
12. 

    Roland Haas

    • changed status to closed
    • edited description

    • 2019-02-21T19:49:24+00:00
13. Log in to comment