Modify

Opened 17 months ago

Last modified 17 months ago

#2070 reopened defect

shallow checkouts do not work with branches

Reported by: Roland Haas Owned by:
Priority: minor Milestone:
Component: GetComponents Version: development version
Keywords: Cc:

Description

Currently using both --shallow and a branch (rather than master) fails since GetComponents wants to first clone the full repo then switch to the requested branch which fails with a shallow clone.

However newer versions of git (>=1.7) support a "-b" (branch) option for clone and that one works fine even with shallow clones.

My recollection is that we could not use this method initially since there were clusters around that only offered git 1.6 (queenbee likely). This is no longer the case and all clusters in simfactory offer at least git 1.7.

This pull request:

https://github.com/gridaphobe/CRL/pull/6/files

both fixes the problem and simplifies the code.

Attachments (0)

Change History (3)

comment:1 Changed 17 months ago by Roland Haas

Status: newreview

comment:2 Changed 17 months ago by Frank Löffler

As far as I can see, the patch only removes the branch functionality. It doesn't move it to the regular checkout (it doesn't add the mentioned "-b" option there). Wouldn't that leave shallow clones of branches still in master?

Last edited 17 months ago by Frank Löffler (previous) (diff)

comment:3 Changed 17 months ago by Roland Haas

Status: reviewreopened

Hello Frank,

correct. Must have removed it with some other debug code. Will update.

Yours,
Roland

Modify Ticket

Change Properties
Set your email in Preferences
Action
as reopened The ticket will remain with no owner.
Next status will be 'review'.
as The resolution will be set.
to The owner will be changed from (none) to the specified user.
The owner will be changed from (none) to anonymous.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.