Scheduling of GRHydro_SqrtSpatialDeterminant.

Comments (6)

1. 

   Roland Haas

   • removed comment

   Should we maybe ensure instead that HydroBase_Prim2ConInitial runs after ADMBase_PostInitial and that GRHydro_SqrtSpatialDeterminant runs in between?

   • 2017-11-20T10:46:35+00:00
2. 

   Eloisa Bentivegna reporter

   • removed comment

   Well, GRHydro_SqrtSpatialDeterminant is already scheduled to run before HydroBase_Prim2ConInitial, so if the former runs after ADMBase_PostInitial, the latter will too. Are there practical cases where the two suggestions differ? (Or are you just proposing a logically better solution?)

   Note: my first patch had the new constraint in the BEFORE block, not in AFTER. I just replaced it.

   • 2017-11-20T13:31:33+00:00
3. 

   Roland Haas

   • removed comment

   The logic is flawed :-). Just because both GRHydro_SqrtSpatialDeterminant and ADMBase_PostInitial are scheduled to run before HydroBase_Prim2ConInitial, no ordering is yet imposed between GRHydro_SqrtSpatialDeterminant and ADMBase_PostInitial. Your updated patch does impose a correct ordering though.

   I think my original comment was based on not knowing on top of my head whether HydroBase_Prim2ConInitial was scheduled to run after ADMBase_PostInitial or not.

   Your patch looks fine to me. Please apply (do you have commit rights?).

   • 2017-11-20T13:58:43+00:00
4. 

   Eloisa Bentivegna reporter

   • removed comment

   I do have commit rights, and have just applied the patch.

   • 2017-11-21T05:03:36+00:00
5. 

   Roland Haas

   • changed status to resolved
   • removed comment

   Thank you.

   • 2017-11-21T09:18:21+00:00
6. 

   Roland Haas

   • edited description
   • changed status to closed

   • 2019-02-21T20:05:15+00:00
7. Log in to comment