GetComponents should not prompt in a Jupyter notebook

Comments (4)

1. 

   Roland Haas

   • changed status to open
   • removed comment

   Please set the ticket state to "review" if you'd like a patch reviewed.

   • 2017-12-07T11:45:26+00:00
2. 

   Roland Haas

   • changed status to open
   • removed comment

   Looks like a hack. Ideally one would not want to tie this to just jupyter yet it seems impossible to find out if the user could actually respond since jupyter insists on creating a tty (and then does not properly support it since once cannot read from stdin :-( ).

   There is a second change in there that now uses $answer instead of "no" in the default shown to the user. This involves no functional change since $answer has already been initialized to "no" at this point and is actually an improvement since it shows the actual default that will be used and not what the author of the code thinks that default was.

   So ok to apply to master only, please make this two commits, one for the $answer change, one for the jupyter support.

   • 2017-12-07T11:45:32+00:00
3. 

   Steven R. Brandt reporter

   • changed status to resolved
   • removed comment

   Fixed in a26dcd216cf97d6776b10a2fd27fe70cd24259b8 of https://github.com/gridaphobe/CRL.git

   • 2017-12-07T14:41:17+00:00
4. 

   Roland Haas

   • edited description
   • changed status to closed

   • 2019-02-21T20:05:14+00:00
5. Log in to comment