Modify

Opened 12 months ago

Last modified 12 months ago

#2120 review task

check that all parfiles that set ADMMacros::spatial_order also set GRHydro::sources_spatial_order to the same value

Reported by: Roland Haas Owned by:
Priority: minor Milestone: ET_2018_02
Component: EinsteinToolkit thorn Version: development version
Keywords: GRHydro Cc:

Description

Since GRHydro switched from ADMMacros to its own finite differencing for the Christoffels in the source term, we must make sure that the change was propagated to all parfiles. We may even want to check in GRHydro's paramcheck that, if ADMMacros is active its spatial_order parameter agrees with GRHydro's sources_spatial_order which should capture all legacy parfiles that need updating.

Attachments (0)

Change History (2)

comment:1 Changed 12 months ago by Roland Haas

Status: newreview

Turns out I had written such code in 2016-06 but apparently never pushed it. This is not in a pull request:

https://bitbucket.org/einsteintoolkit/einsteinevolve/pull-requests/11/grhydro-add-check-when-admmacros/diff

comment:2 Changed 12 months ago by Roland Haas

To be included only after the release. Testing of course that all parfiles are correct should happen before the release.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as review The ticket will remain with no owner.
Next status will be 'reviewed_ok'.
as The resolution will be set.
The resolution will be deleted.
to The owner will be changed from (none) to the specified user.
to The owner will be changed from (none) to the specified user.
The owner will be changed from (none) to anonymous.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.