Modify

Opened 9 months ago

Closed 6 weeks ago

#2126 closed defect (fixed)

SimFactory should choose an appropriate cfg on a Mac.

Reported by: Steven R. Brandt Owned by:
Priority: unset Milestone: ET_2018_08
Component: SimFactory Version: development version
Keywords: Cc:

Description

generic.cfg does not work on a mac because gcc doesn't exist (one needs to use gcc-7 instead, for example). Simfactory should detect and use the correct cfg file from the set generic.cfg, osx-homebrew.cfg, and osx-macports.cfg.

Attachments (0)

Change History (7)

comment:2 Changed 8 months ago by Roland Haas

Status: reviewreopened

Please see comments inline in pull request. Cannot be applied as is, and should provide some more robust error checking as well as a statement that this was actually tested by someone (since as far as I know you do not use / or had access to) a mac in the past.

comment:3 Changed 8 months ago by Steven R. Brandt

Roland and I are at an impasse discussing this ticket on the pull request. Other opinions would be welcome.

comment:4 Changed 8 months ago by Steven R. Brandt

I just did an experiment. I compiled on a Mac with homebrew using generic.cfg. The obvious problem with doing things this way is that "gcc" is really clang.

However, despite Mac lying about the compiler, Cactus compiled and the test suite ran (except for Memspeed). Given this, I think we can modify the tutorial to remove the Mac-specific instructions and close this ticket.

Ian, could you test to see if this works on a mac ports install also?

Last edited 8 months ago by Steven R. Brandt (previous) (diff)

comment:5 Changed 6 weeks ago by Steven R. Brandt

comment:6 Changed 6 weeks ago by Roland Haas

Looks mostly good. I have added couple of comments to the pull request.

Cannot be pushed to master as is since it contains leftover print statements from debugging it seems. There are some minor things that should be fixed as well and one has to consider what happens on eg debian (and likely Ubuntu) systems where there is a gcc and a gcc-N but gcc is the real thing this time (and points to one of the gcc-N based on either user choice or on the distro settings and gcc is the one that is compatible with most packages provided by the distro while gcc-N may not be).

comment:7 Changed 6 weeks ago by Steven R. Brandt

Resolution: fixed
Status: reopenedclosed

Pull request applied in d81d8f57dde190e7a81043ba08030c459fbd7399 of https://bitbucket.org/simfactory/simfactory2.git

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The ticket will remain with no owner.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.