Modify

Opened 9 months ago

Last modified 9 months ago

#2128 review defect

Hydro_RNSID should not inherit from GRHydro

Reported by: zachetie@… Owned by:
Priority: major Milestone:
Component: Other Version: development version
Keywords: Hydro_RNSID Cc:

Description

Hydro_RNSID will not compile without GRHydro, as apparently it inherits some variable(s) from GRHydro. Being a hydro initial data thorn, it should only depend on HydroBase & ADMBase.

Attachments (0)

Change History (4)

comment:1 Changed 9 months ago by Roland Haas

Keywords: Hydro_RNSID added
Status: newconfirmed

comment:2 Changed 9 months ago by Roland Haas

Pull request which removes GRHydro dependency is here:
https://bitbucket.org/einsteintoolkit/einsteininitialdata/pull-requests/4/hydro_rnsid-remove-dependency-on-grhydro/diff

This so far is untested and while in principle there should be no change in data since GRHydro alsready schedules an InitialPrim2Con routine there may be differences in the atmosphere treatment and / or for past timelevels.

comment:3 Changed 9 months ago by Roland Haas

Priority: unsetmajor

comment:4 Changed 9 months ago by Roland Haas

Status: confirmedreview

Modify Ticket

Change Properties
Set your email in Preferences
Action
as review The ticket will remain with no owner.
Next status will be 'reviewed_ok'.
as The resolution will be set.
The resolution will be deleted.
to The owner will be changed from (none) to the specified user.
to The owner will be changed from (none) to the specified user.
The owner will be changed from (none) to anonymous.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.