- changed status to open
- removed comment
Hydro_RNSID should not inherit from GRHydro
Issue #2128
closed
Hydro_RNSID will not compile without GRHydro, as apparently it inherits some variable(s) from GRHydro. Being a hydro initial data thorn, it should only depend on HydroBase & ADMBase.
Keyword: Hydro_RNSID
Comments (10)
-
-
- removed comment
Pull request which removes GRHydro dependency is here: https://bitbucket.org/einsteintoolkit/einsteininitialdata/pull-requests/4/hydro_rnsid-remove-dependency-on-grhydro/diff
This so far is untested and while in principle there should be no change in data since GRHydro alsready schedules an InitialPrim2Con routine there may be differences in the atmosphere treatment and / or for past timelevels.
-
-
- changed status to open
- removed comment
-
I have updated the pull request so that it again applies cleanly (and removed the GRHydro data from the testsuites). The pull request is ready to be reviewed.
-
- edited description
- changed status to on hold
Wait for a couple of days for the dust of ET_2019_03 to settle, then apply since @zach_etienne says "please apply" in the pull request.
-
I updated the pull request as follows:
- removed all output for it>0 which is no longer generated once GRhydro is removed
- removed out_info comments from output
- removed ADMConstraints output which relies on Tmunu which relies on GRHydro
- change RNSID atmo settings to match what GRhydro used
with these changes (none of which changes "actual" data) the tests pass.
-
- changed status to open
Release is done, now merge in.
-
- changed status to resolved
Applied as git hash 742210fd0fc0 "Hydro_RNSID: make RNSID atmosphere match previous GRHydro setting" of einstieninitialdata.
-
- changed status to closed
- Log in to comment
- Assignee
- –
- Type
- Priority
- Status
- closed
- Component
- Other
- Milestone
- –
- Version
- development version
- Votes
- 0
- Watchers
- 0
