Modify

Opened 2 months ago

Closed 4 weeks ago

#2155 closed defect (fixed)

Fixed bug in calculation of conserved S vector in MHD Prim2Con

Reported by: hannah.klion@… Owned by:
Priority: major Milestone:
Component: EinsteinToolkit thorn Version: development version
Keywords: backport Cc:

Attachments (0)

Change History (4)

comment:1 Changed 2 months ago by anonymous

Status: newreview

comment:2 Changed 2 months ago by anonymous

Priority: minormajor

This bug produces incorrect physics since it computes the current densities incorrectly for MHD simulations using GRHydro using the C++ code.

comment:3 Changed 4 weeks ago by Roland Haas

The F90 code uses:

  dsx = sdet * ((drho*(1+deps)+dpress+b2)*w*w * vlowx - &
       ab0*blowx)

and the papers (https://arxiv.org/abs/1304.5544 eq. 11) give:

S_j = sqrt(detg) (ρh W v_j − α b_0 b_j)

I have accepted the pull request and backported into the release code.

We should send out an announcement since this affected science runs using default Einstein Toolkit parameters since commit fe5578d1d28d813cee37e35df69572ddc2f0ef71 "GRHydro: enable C++ code by default" from Mon Feb 23 00:01:14 2015 (and all code using the cxx flavor of GRHydro's MHD code since its inception).

comment:4 Changed 4 weeks ago by Roland Haas

Keywords: backport added
Resolution: fixed
Status: reviewclosed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The ticket will remain with no owner.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.