Fixed bug in calculation of conserved S vector in MHD Prim2Con

Comments (5)

1. 

   anonymous

   • changed status to open
   • removed comment

   • 2018-05-22T07:51:41+00:00
2. 

   anonymous

   • marked as
   • removed comment

   This bug produces incorrect physics since it computes the current densities incorrectly for MHD simulations using GRHydro using the C++ code.

   • 2018-05-22T08:04:00+00:00
3. 

   Roland Haas

   • removed comment

   The F90 code uses:

     dsx = sdet * ((drho*(1+deps)+dpress+b2)*w*w * vlowx - &
          ab0*blowx)
   

   and the papers (https://arxiv.org/abs/1304.5544 eq. 11) give:

   S_j = sqrt(detg) (ρh W v_j − α b_0 b_j)
   

   I have accepted the pull request and backported into the release code.

   We should send out an announcement since this affected science runs using default Einstein Toolkit parameters since commit fe5578d1d28d813cee37e35df69572ddc2f0ef71 "GRHydro: enable C++ code by default" from Mon Feb 23 00:01:14 2015 (and all code using the cxx flavor of GRHydro's MHD code since its inception).

   • 2018-06-20T08:49:37+00:00
4. 

   Roland Haas

   • changed status to resolved
   • removed comment

   • 2018-06-20T08:51:31+00:00
5. 

   Roland Haas

   • edited description
   • changed status to closed

   • 2019-02-21T20:04:47+00:00
6. Log in to comment