- removed comment
Fix small memory leak in Piraha
Issue #2208
closed
This pull request
https://bitbucket.org/cactuscode/cactus/pull-requests/54/piraha-mem/diff
Fixes a small memory leak caused by a cyclic reference.
Keyword: None
Comments (5)
-
-
reporter
- changed status to open
- removed comment
The pull request has been updated to address Roland's concern.
-
- changed status to open
- removed comment
Please apply.
-
reporter
- changed status to resolved
- removed comment
-
- changed status to closed
- edited description
- Log in to comment
- Assignee
- –
- Type
- Priority
- Status
- closed
- Component
- Cactus
- Milestone
- ET_2019_02
- Version
- development version
- Votes
- 0
- Watchers
- 0
Steve and Roland discussed this in person at SC18. Roland asks to have the prototype of the constructor changed to take a bare pointer rather than a smart-pointer to make it more obvious for callers of the Lookup objects that they store a bare pointer to the their grammar.
The current logic in piraha should be such that the grammar object exists for as long as the lookup objects exist so the pointer should not become dangling.