Meudon_Bin_NS parameter eos_table_filepath ignored by LORENE1
Issue #2212
resolved
It seems that only LORENE2 respects the parameter eos_table_filepath of Meudon_Bin_NS (which is passed on as an env variable LORENE_TABULATED_EOS_PATH by the Thorn and interpreted by the modified version of LORENE stored in LORENE2/dist/Lorene.tar).
Either LORENE1 should modified via a patch to support the same functionality or (less desireable) Meudon_Bin_NS should check the version of LORENE it is linked against or (even less so) there should be a comment in param.ccl warning that the parameter is ignored by older versions of LORENE.
Note that the check needs to be at runtime since we still must be able to build Meudon_Bin_NS against the old version of LORENE.
Keyword: Meudon_Bin_NS
Comments (9)
-
reporter
-
reporter
Encountered in real live in
#2453. -
reporter
Pull request https://github.com/EinsteinToolkit/ExternalLibraries-LORENE/pull/2 applies the fragment identified in #2206 to LORENE1.
-
reporter
- edited description
- changed status to open
-
reporter
- edited description
-
assigned issue to
Roland Haas
-
reporter
Please review.
-
reporter
Unless objected I will apply this after 2021-02-18
-
reporter
Applied as git hash cc976b7 "LORENE: support setting eos table file path" of ExternalLibraries-LORENE which adds functionality that
Meudon_Bin_NSneeds to control the EOS file path. -
reporter
- changed status to resolved
- Log in to comment
- Assignee
- Type
- Priority
- Status
- resolved
- Component
- EinsteinToolkit thorn
- Milestone
- –
- Version
- development version
- Votes
- 0
- Watchers
- 0
Issue
#2453was marked as a duplicate of this issue.