Modify

Opened 13 days ago

Closed 6 days ago

#2216 closed enhancement (fixed)

Vectors: allow seamless interaction with scalar types

Reported by: Roland Haas Owned by:
Priority: minor Milestone:
Component: EinsteinToolkit thorn Version: development version
Keywords: Vectors Cc:

Description

  • Vectors: allow implicit cast from scalar_t
  • Vectors: provide binary operations with scalars

one needs both

operatorX(T, vectype<T>)

and

operatorX(vectype<T>, T)

for both commuting and non-commuting operators

Pull request is here: https://bitbucket.org/cactuscode/cactusutils/pull-requests/16/rhaas-inclict-conv/diff

Attachments (0)

Change History (5)

comment:1 Changed 13 days ago by Roland Haas

Status: newreview

comment:2 Changed 13 days ago by Erik Schnetter

I see you define operators for + and *. What about subtraction and division?

comment:3 Changed 6 days ago by Roland Haas

Erik says (offline communication): "please apply".

comment:4 Changed 6 days ago by Roland Haas

Status: reviewreviewed_ok

comment:5 Changed 6 days ago by Roland Haas

Resolution: fixed
Status: reviewed_okclosed

Applied as git hash cf7053e "Vectors: make all conversion ops templates" of cactusutils.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The ticket will remain with no owner.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.