more OpenMP WORKSHARE sections in GRHydro Reconstruct

Comments (4)

1. 

   Roland Haas reporter

   • changed status to open
   • removed comment

   • 2011-03-02T08:29:43+00:00
2. 

   Erik Schnetter

   • removed comment

   For best OpenMP performance, there should probably be as few parallel regions as possible. In general, a single parallel region per routine would be best (unless the routine has a complex structure).

   Some of your patch reads as if the current code had workshare constructs outside of a parallel region. This would be senseless and looks like a bug to me.

   I think that if statements inside a workshare construct are fine (I'm not completely sure about this). In this case, code such as

   if (shift_state .ne. 0) then 120 !$OMP WORKSHARE 115 121 lbetax = betax 116 122 lbetay = betay 117 123 lbetaz = betaz 124 !$OMP END WORKSHARE NOWAIT 118 125 else 126 !$OMP WORKSHARE 119 127 lbetax = 0.d0 120 128 lbetay = 0.d0 121 129 lbetaz = 0.d0 130 !$OMP END WORKSHARE NOWAIT 122 131 end if

   could be simplified to have only a single, enclosing workshare construct.

   • 2011-03-02T08:37:05+00:00
3. 

   Roland Haas reporter

   • changed status to resolved
   • removed comment

   • 2011-03-02T20:18:21+00:00
4. 

   Roland Haas reporter

   • edited description
   • changed status to closed

   • 2019-02-21T20:24:58+00:00
5. Log in to comment