Modify

Opened 7 years ago

Last modified 7 years ago

#332 new defect

Cactus should not interpret environment variables as configuration options

Reported by: Ian Hinder Owned by:
Priority: major Milestone:
Component: Cactus Version:
Keywords: Cc:

Description

Currently, if you have the variable HDF5_DIR set in your shell startup file, Cactus will interpret this as a configuration option and will override whatever is set in your optionlist.

This behaviour occurs because the "make" utility allows you to specify options on the command line which are then converted into environment variables. This is a method for overriding options on the command line.

However, the fact that variables from the user's environment are also overriding the optionlist is very undesirable. It would be good if this could be fixed somehow.

This ticket is in response to #100.

Attachments (1)

cactus.py (18.0 KB) - added by Erik Schnetter 7 years ago.
Cactus makefile replacement

Download all attachments as: .zip

Change History (3)

Changed 7 years ago by Erik Schnetter

Attachment: cactus.py added

Cactus makefile replacement

comment:1 Changed 7 years ago by Erik Schnetter

One good way around this would be to rewrite the top-level Cactus makefile in Python. This top-level makefile does not use any real make facilities; it only parses the command and then calls the corresponding "real" makefile in the lib/make directory.

Rewriting this makefile should be straightforward. I began to do this some time ago; I attach the current state of my efforts.

comment:2 Changed 7 years ago by anonymous

Replacing the Makefile is not a bad idea, but I am not so sure using python would be the best option. Given how many problems we see with simfactory and different versions of python being installed (or not) one various systems, one would have to be very careful and test a lot. The logic isn't all that complicated, and the rest of the build system is in perl anyway - IHMO it would make most sense to have the global "Makefile" in perl as well.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The ticket will remain with no owner.
Next status will be 'review'.
as The resolution will be set.
to The owner will be changed from (none) to the specified user.
Next status will be 'confirmed'.
The owner will be changed from (none) to anonymous.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.