Called with the current ET thornlist, warning messages are displayed

Issue #37 closed
Frank Löffler created an issue

Calling GetComponents with the current ET thornlist displayes (incomplete) warning messages:

$ ./GetComponents -a http://svn.einsteintoolkit.org/manifest/trunk/einsteintoolkit.th Use of uninitialized value $rec{"URL"} in concatenation (.) or string at ./GetComponents line 371.

Nothing will be checked out from


Checking out module: manifest from repository: https://svn.einsteintoolkit.org/manifest/trunk

Keyword:

Comments (4)

  1. Erik Schnetter
    • removed comment

    This is caused by the last block in the thorn list, which gives an example for listing purely local thorns that are not in any repository. These lines are

    1. Private thorns !TARGET = $ARR !TYPE = ignore !CHECKOUT =

    which do not list any thorns to check out. This empty list seems to cause this warning. Otherwise, the warning seems to be harmless.

    Allowing empty checkout blocks is useful, e.g. as example (here), or to allow people to easily comment out all thorns from a repository.

  2. Eric Seidel
    • changed status to open
    • removed comment

    Thanks, I'm attaching a patch that fixes the issue. I'll apply it later unless there are objections.

  3. Log in to comment