Modify

Opened 8 years ago

Last modified 7 years ago

#395 new enhancement

Thorns providing interpolator routines should provide testcases for them

Reported by: Frank Löffler Owned by:
Priority: minor Milestone:
Component: Other Version:
Keywords: Cc:

Description

Errors in the interpolator often show up in the output of other thorns, depending on those interpolating routines. Figuring out that this is caused by problem while interpolating can take quite a bit of time, which could be saved if the interpolating thorns would include testsuites themselves.

Attachments (0)

Change History (7)

comment:1 Changed 8 years ago by Erik Schnetter

There are test cases in CarpetInterp and in InterpToArray.

comment:2 Changed 8 years ago by Frank Löffler

Right, InterpToArray contains one testsuite. The "problem" with the testsuites in CarpetInterp is that they use thorns outside of the ET (wavetoy). It would be nice to have testsuites working within the ET, which would require to either include those wavetoy thorns, or to add testsuites using e.g. analytically setup data (carefully not suggesting Exact).

comment:3 Changed 8 years ago by Roland Haas

As long as we interpolate only the metric Exact would be fine, wouldn't it? The metric itself does not require interpolation (we do not want an evolution for the interpolator tests, do we?) We could also use say the gauge wave initial data thorns. Anything that uses some analytic expression to fill in a grid function with non-constant data would seem fine to me.

comment:4 Changed 8 years ago by Erik Schnetter

We have many other initial data thorns in addition to Exact.

I think WaveToy is small, we could just add it.

comment:5 Changed 8 years ago by Ian Hinder

Interpolation within Carpet (i.e. for prolongation, which is separate from that provided by AEILocalInterp) is tested using a polynomial for which interpolation of the correct order (at least for some interpolators) is exact. This means that the correct solution is trivial and it's obvious if the test is correct or not. I propose some sort of initial data thorn for setting polynomial initial data which could be used by the testsuites for the interpolator. This would be part of Cactus, as it is sufficiently generic and useful for testing interpolator thorns. I don't think we should use an Einstein-based initial data thorn for testing the interpolators. This belongs in Cactus, not the ET.

comment:6 Changed 8 years ago by Erik Schnetter

Such a generic routine is part of thorn CarpetExtra/CarpetProlongateTest in the Mercurial version of Carpet.

comment:7 Changed 7 years ago by Ian Hinder

Milestone: ET_2011_10

There is no time to implement additional test cases for interpolators before the release - removing milestone.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The ticket will remain with no owner.
Next status will be 'review'.
as The resolution will be set.
to The owner will be changed from (none) to the specified user.
Next status will be 'confirmed'.
The owner will be changed from (none) to anonymous.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.