- removed comment
Job Chaining
Issue #439
closed
Currently job chaining only works with the first chained job. Subsequent chained jobs are incorrectly set to depend on the current active restart rather than the last queued restart. The attached patch fixes the problem, although I'm not sure if it's the correct approach. It just looks for the largest restart ID (without checking if that restart is in the queue) and sets the new job to depend on that. What is the 'correct' behavior in this situation?
Keyword: job
Keyword: chaining
Comments (3)
-
-
reporter
- changed status to resolved
- removed comment
-
- edited description
- changed status to closed
- Log in to comment
- Assignee
-
anonymous
- Type
- Priority
- Status
- closed
- Component
- SimFactory
- Milestone
- –
- Version
- –
- Votes
- 0
- Watchers
- 0
This seems to be the correct solution. Please apply this patch.
If the MaxJobID is not in the queue, SimFactory should abort with an error. Anything else would lead to a very complex behaviour that would be difficult to understand. You can either add this check to the patch, or (if it's too complicated) add a TODO comment to the code.
This check should be in the actual presubmission code, not in the code that checks whether to presubmit. That is, this TODO comment should not be nearby the changes you are already making.