- removed comment
CartGrid3D symmetries don't work with Carpet-hg
Issue #448
closed
The symmetries implemented in CartGrid3D (bitant, quadrant, and octant mode) do not work with Carpet-HG. They register a symmetry width equal to the number of ghost zones, but do so at a time when the number of ghost zones is not defined. They should instead query CoordBase for the number of boundary points. However, this may break many old parameter files that e.g. use PUGH.
Another alternative would be to always use ReflectionSymmetry with Carpet-HG instead of CartGrid3D's symmetries.
This affects currently e.g. the test case EinsteinAnalysis/AHFinderDirect/test/Kerr-Cartoon.
Keyword:
Comments (6)
-
-
- changed status to open
- removed comment
-
reporter
- removed comment
Please apply.
-
- assigned issue to
- removed comment
-
- changed status to resolved
- removed comment
Committed in r51 of CactusBase/SymBase.
-
- edited description
- changed status to closed
- Log in to comment
The attached patch implements the second suggestion (deprecating these symmetries) by modifying the error message that occurs when Carpet-HG is used with symmetry thorns which don't register symmetries in the correct place.