Improve bboxset efficiency (e.g. for regridding)

Comments (5)

1. 

   Erik Schnetter reporter

   • changed status to open
   • removed comment

   • 2011-06-23T15:08:19+00:00
2. 

   Ian Hinder

   • removed comment

   I've read the patch, but it is too intricate for me to say much about. My only comment is a meta-comment, if you like, that the patch would have been less daunting if the pure-formatting changes had been separated out so I could ignore them.

   Assuming that this has been tested, that Erik is reasonably confident that it is correct, and that any regridding-related tests (do we have any?) pass, I would say to apply this. The only further review that I could really do would be to run a test BBH simulation with this. Do you think this is necessary, or do you just want to apply it?

   Another issue is that we currently have a number of failing tests, which means that seeing additional failures that might come about as a result of this patch might be hard.

   • 2011-09-25T17:54:46+00:00
3. 

   Erik Schnetter reporter

   • removed comment

   Since we are shortly before a freeze I will not commit this change at this time.

   • 2011-09-25T20:23:45+00:00
4. 

   Erik Schnetter reporter

   • changed status to resolved
   • removed comment

   Applied

   • 2011-10-27T14:25:44+00:00
5. 

   Roland Haas

   • edited description
   • changed status to closed

   • 2019-02-21T20:15:40+00:00
6. Log in to comment