Opened 7 years ago

Last modified 7 years ago

#498 new defect

McLachlan doesn't check metric_type

Reported by: Erik Schnetter Owned by:
Priority: minor Milestone:
Component: EinsteinToolkit thorn Version:
Keywords: Cc:


McLachlan doesn't check the metric type, which needs to be "physical". A static conformal factor is not supported.

Attachments (0)

Change History (4)

comment:1 Changed 7 years ago by Erik Schnetter

Actually, McLachlan should check the grid scalar conformal_state, not the parameter metric_type.

comment:2 Changed 7 years ago by Frank Löffler

In general: who is using a static conformal factor these days? If nobody really, I suggest to mark this depreciated for the next release and remove it for the one following that.

comment:3 Changed 7 years ago by Erik Schnetter

It is used in current example parameter files, and mostly unsuspecting people will trip over it. We could mark it as deprecated, but would then need to update these examples (and possibly test cases).

comment:4 Changed 7 years ago by Ian Hinder

I certainly wouldn't put any effort into making McLachlan know about this. Instead spend the time on updating the test cases.

Modify Ticket

Change Properties
Set your email in Preferences
as new The ticket will remain with no owner.
Next status will be 'review'.
as The resolution will be set.
to The owner will be changed from (none) to the specified user.
Next status will be 'confirmed'.
The owner will be changed from (none) to anonymous.

Add Comment

E-mail address and name can be saved in the Preferences.

Note: See TracTickets for help on using tickets.