Modify

Opened 7 years ago

Last modified 7 years ago

#510 reopened enhancement

Reduce default verbosity

Reported by: Ian Hinder Owned by: Erik Schnetter
Priority: minor Milestone:
Component: SimFactory Version:
Keywords: Cc:

Description

SimFactory has an option --verbose which defaults to True. This has been useful while SimFactory was in heavy development and there were frequent problems and errors where the extra information provided by --verbose gave useful context to debugging.

Now that SimFactory is in regular production use with fewer problems, and the plan is to make it the default for the Einstein Toolkit, I propose to change the verbosity to False. This makes the tool appear less intimidating for new users and leads to an overall smoother, slicker experience. All information should be available in the simulation log file for debugging purposes if required.

The attached patch implements this. There are still some messages which are output anyway, and these will need to be addressed one by one. Also, the --verbose setting does not appear to propagate across remote invocations of simfactory. But these are separate from the decision to make --no-verbose the default.

Attachments (1)

0004-Make-no-verbose-the-default.patch (603 bytes) - added by Ian Hinder 7 years ago.

Download all attachments as: .zip

Change History (5)

Changed 7 years ago by Ian Hinder

comment:1 Changed 7 years ago by Ian Hinder

Status: newreview

comment:2 Changed 7 years ago by Erik Schnetter

Please apply.

comment:3 Changed 7 years ago by Ian Hinder

Resolution: fixed
Status: reviewclosed

Applied in r1426

comment:4 Changed 7 years ago by Erik Schnetter

Resolution: fixed
Status: closedreopened

The documentation needs to be updated, including the FAQ. Since this change is very use visible and affects debugging, it should also be announced on the Cactus mailing list, and we need to make sure it is mentioned in the release notes.

We could also check for SILENT in the Makefile and output an error message if it has been set, or we could set VERBOSE (if it is not set) from SILENT (if it is set), so that we remain backward compatible for some time.

Some other thorns may check the value of SILENT; I know that e.g. Formaline does. These thorns need to be updated, unless we keep a variable SILENT around for compatibility.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as reopened The owner will remain Erik Schnetter.
Next status will be 'review'.
as The resolution will be set.
to The owner will be changed from Erik Schnetter to the specified user.
The owner will be changed from Erik Schnetter to anonymous.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.