1. Einstein Toolkit Avatar Einstein Toolkit
  2. Einstein Toolkit
  3. tickets
  4. Issues

Make signbit in Vectors work on more architectures

Issue #513 closed
Erik Schnetter created an issue

Several C++ compilers cannot handle std::signbit. There is also a namespace problem when using the same identifier Vectors_SGN for different precisions (real4 and real8). In addition, kifpos is implemented incorrectly on several architectures. The attached patch corrects these.

Keyword:

Comments (4)

  2. Barry Wardell
    • removed comment

    The changes look good to me. I've tested the SSE and default versions and they all compile and pass the Vectors testsuite on Damiana, Datura and my laptop. They also compile on Scientific Linux 6 which previously caused problems for me.

    I didn't test the Altivec, DoubleHummer or VSX changes but they look correct. Any errors should be caught by the testsuites, so assuming those pass, I think this should be be committed.

  5. Log in to comment
Assignee
–
Type
bug
Priority
minor
Status
closed
Component
EinsteinToolkit thorn
Milestone
–
Version
–
Votes
0
Watchers
0
Jira Software: the preferred issue tracker for Bitbucket. Join the team!