Modify

Opened 7 years ago

Last modified 7 years ago

#538 new enhancement

Enable CSE in McLachlan

Reported by: Erik Schnetter Owned by:
Priority: minor Milestone:
Component: EinsteinToolkit thorn Version:
Keywords: Cc:

Description

Kranc supports CSE, which has the potential to reduce code size and improve performance. We should enable it in McLachlan.

Attachments (0)

Change History (4)

comment:1 Changed 7 years ago by Frank Löffler

What out of http://en.wikipedia.org/wiki/CSE is the CSE you mean? :)

comment:2 Changed 7 years ago by Erik Schnetter

The one activated by the UseCSE->True flag, <http://en.wikipedia.org/wiki/Common_subexpression_elimination>.

comment:3 Changed 7 years ago by Ian Hinder

Does CSE lead to improved performance on some systems? I believe Barry found that it gave improvements for !WeylScal4 but not for McLachlan, but I might be misremembering.

comment:4 Changed 7 years ago by Barry Wardell

Yes, when I was testing it, I found that it actually slowed McLachlan down a bit, but did give a speedup for !WeylScal4. This was before a lot of the recent speed improvements in McLachlan so it would be worth checking again. I don't think we should just blindly enable it, though.

The benefits of CSE might also depend on e.g. whether Jacobians are enabled or not, how aggressive the CSE is (this can be tuned), etc.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The ticket will remain with no owner.
Next status will be 'review'.
as The resolution will be set.
to The owner will be changed from (none) to the specified user.
Next status will be 'confirmed'.
The owner will be changed from (none) to anonymous.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.