- removed comment
ADMBase: Change default value of initial_shift parameter to "zero"
Issue #565
closed
Currently the default value of initial_shift is "none". GRHydro doesn't support shift_state = 0 anymore for example, and I believe most of the codes do need storage for the shift vector. So I was wondering if it wouldn't be better to change the default for the initial_shift parameter from "none" to "zero". Any opinions about it?
Keyword:
Comments (4)
-
-
reporter
- removed comment
If nobody opposes, I would like to change this later today.
Thanks.
-
reporter
- changed status to resolved
- removed comment
Change commited.
-
- edited description
- changed status to closed
- Log in to comment
- Assignee
- –
- Type
- Priority
- Status
- closed
- Component
- EinsteinToolkit thorn
- Milestone
- –
- Version
- –
- Votes
- 0
- Watchers
- 0
I think this would avoid a lot of problems for beginner (and not so beginner!) users and mysterious segfaults. Any codes which don't need a shift probably don't care much about the additional memory that this change would cause to be wasted.