Pass unallocated arrays to Fortran as NULL pointers

Comments (5)

1. 

   Erik Schnetter reporter

   • changed status to open
   • removed comment

   • 2011-09-26T15:24:24+00:00
2. 

   Roland Haas

   • removed comment

   while I think I can definitely construct a situation where a compiler is perfectly correct in trying to access the NULL pointer, namely something like:

   CCTK_REAL gxx(cctk_lsh(1), cctk_lsh(2), cctk_lsh(3)) CCTK_REAL betax(cctk_lsh(1), cctk_lsh(2), cctk_lsh(3)) ... gxxL = gxx(i,j,k) if(shift_state.ne.0) then bx = betax(i,j,k) else bx = 0.0 endif

   I think that unless we actually know of a compiler that gives segfaults in this case I would think that the benefit of having unallocated grid functions detected in Fortran outweights the undocumented behaviour we exploit here (plus we are already using undocumented/compiler-specific features when calling Fortran code from C).

   I compiles for me and seems to not crash the testsuites (gcc 4.6). Please apply.

   • 2011-09-28T20:27:57+00:00
3. 

   Frank Löffler

   • removed comment

   Erik: did you change your mind and don't want to apply it?

   • 2011-11-08T08:44:23+00:00
4. 

   Erik Schnetter reporter

   • changed status to resolved
   • removed comment

   I did not change my mind -- I only did not want to apply this shortly before the release.

   Applied.

   • 2011-11-09T07:15:54+00:00
5. 

   Roland Haas

   • changed status to closed
   • edited description

   • 2019-02-21T20:23:46+00:00
6. Log in to comment