Modify

Opened 7 years ago

Last modified 4 years ago

#582 assigned enhancement

Semi-automatically split McLachlan's calculations

Reported by: Erik Schnetter Owned by:
Priority: major Milestone:
Component: EinsteinToolkit thorn Version:
Keywords: Cc:

Description

Split McLachlan's calculations semi-automatically in two ways: (a) by variable, so that e.g. dot[g] and dot[K] are calculated separately, and (b) by pattern, so that advection terms, dissipation, and "everything else" are calculated separately. Also introduce parameters to choose which routines are called at run time.

This is somewhat a work in progress, in that the patch is good, but the API defined to split kernels is more complex and less failsafe than it should be.

Attachments (1)

ml-separate.diff (28.7 KB) - added by Erik Schnetter 7 years ago.

Download all attachments as: .zip

Change History (11)

Changed 7 years ago by Erik Schnetter

Attachment: ml-separate.diff added

comment:1 Changed 7 years ago by Erik Schnetter

Status: newreview

comment:2 Changed 7 years ago by Ian Hinder

(Erik and I already discussed this out of TRAC - I put the following here for the benefit of others)

This makes for a much more complicated !McLachlan_BSSN.m. I would rather that the splitting itself was done within Kranc. You could give Kranc the original unsplit calculations, and give it patterns to match against the terms which are candidates for splitting. Kranc would then process the calculations and generate the different variants. This way, the splitting, which is an implementation/optimisation detail, is hidden from the end-user, who only has to worry about the equations. It's good to have this patch here in TRAC so that we can use it as a reference, now that I see the idea of what you are trying to do. We just need to move the logic from this patch into Kranc.

comment:3 Changed 7 years ago by Frank Löffler

Status: reviewreopened

comment:4 Changed 7 years ago by Frank Löffler

Owner: set to Erik Schnetter
Status: reopenedassigned

comment:5 Changed 7 years ago by Erik Schnetter

Owner: changed from Erik Schnetter to Ian Hinder

comment:6 Changed 7 years ago by Erik Schnetter

Last edited 7 years ago by Erik Schnetter (previous) (diff)

comment:7 Changed 7 years ago by Erik Schnetter

Resolution: fixed
Status: assignedclosed
Last edited 7 years ago by Erik Schnetter (previous) (diff)

comment:8 Changed 7 years ago by Erik Schnetter

Resolution: fixed
Status: closedreopened

Not committed.

comment:9 Changed 6 years ago by Ian Hinder

The corresponding feature in Kranc is discussed in https://github.com/ianhinder/Kranc/issues/45. Development will occur there. I will leave this ticket open, so that when the features are fully implemented in Kranc, they can be incorporated into McLachlan.

comment:10 Changed 4 years ago by Ian Hinder

Owner: Ian Hinder deleted
Status: reopenedassigned

McLachlan has been rewritten (rewrite branch) since this patch, so it is no longer applicable.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as assigned The ticket will remain with no owner.
Next status will be 'review'.
as The resolution will be set.
to The owner will be changed from (none) to the specified user.
The owner will be changed from (none) to anonymous.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.