Modify

Opened 7 years ago

Closed 6 weeks ago

#660 closed defect (fixed)

Make MHD multipatch-aware

Reported by: Tanja Bode Owned by: Tanja Bode
Priority: major Milestone:
Component: EinsteinToolkit thorn Version: development version
Keywords: Cc:

Description

At least the Con2PrimM routines need to be multipatch-aware.

Attachments (0)

Change History (7)

comment:1 Changed 6 years ago by Erik Schnetter

Is this now the case?

comment:2 Changed 6 years ago by Roland Haas

see #676. #676 seems to be a sub-ticket of this ticket.

Yes. Some more have been added to the Zelmani version mostly since I had them added and did want to avoid extensive conflicts with Philipp once he started working on MHD and the hot EOS. This is also the reason why they are not yet in the main branch, since they touch code that keeps changing.

Mostly this affects MHD routines, *however* also eg the Marquina Riemann solver seems to be affected.

comment:3 Changed 5 years ago by Frank Löffler

Status: newreview

I believe this can now be closed, but I would like to have an ackn.

comment:4 Changed 5 years ago by Roland Haas

Let me check on the MHD + multipatch status. Not sure if all routines have been updated.

comment:5 Changed 5 years ago by reisswig@…

I have done some runs with multipatch (however, matter + B-field still located on central Cartesian grid). Everything looks fine to me.

comment:6 Changed 5 years ago by Roland Haas

Status: reviewreopened

Nothing to review here.

comment:7 Changed 6 weeks ago by Roland Haas

Resolution: fixed
Status: reopenedclosed

The main MHD code seems multipatch-aware however there is vector potential code that was never production ready that is not aware. I have added checks to abort the code in that case in git hash 2e99f43 "GRHydro: abort if Llama is used with AVec evolution" of einsteinevolve.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Tanja Bode.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.