Cleanup in script CreateConfigurationBindings.pl

Comments (6)

1. 

   Erik Schnetter reporter

   • changed status to open
   • removed comment

   • 2011-11-26T11:20:08+00:00
2. 

   Ian Hinder

   • removed comment

   This looks OK - please apply.

   • 2012-01-16T09:48:25+00:00
3. 

   Frank Löffler

   • removed comment

   Was this applied?

   • 2012-03-08T23:38:37+00:00
4. 

   Bruno Mundim

   • removed status
   • removed comment

   This patch clean-up CreateConfigurationBindings.pl in several different ways: rename scalar variables to improve readability, get rid of temporary variable, apply proper variable scoping, reorder script execution. I looked carefully into this patch and have only two minor comments (that can be addressed after applying this patch):

   1) In the original file there was not prepending of #include as it shows now on line 104 of the patched file:

   1. Prepend #include $inc =~ s/^(.*)/#include $1/gm; $incs .= $inc;

   Was this intentional?

   2) Fix typo on line 110: # These string --> # These strings

   Other than that the patch looks good and improves readability of the script. Please apply!

   • 2012-04-18T18:18:27+00:00
5. 

   Erik Schnetter reporter

   • changed status to resolved
   • removed comment

   (1) Yes, this was missing (2) Thanks

   • 2012-04-18T18:44:43+00:00
6. 

   Roland Haas

   • edited description
   • changed status to closed

   • 2019-02-21T20:22:33+00:00
7. Log in to comment