Modify

Opened 7 years ago

Last modified 6 years ago

#705 new enhancement

Activation Order in Parameter Files

Reported by: Steven R. Brandt Owned by:
Priority: minor Milestone:
Component: Cactus Version:
Keywords: Cc:

Description

At the moment the ActiveThorns list is sensitive to the order in which thorns are activated if the ActiveThorns parameter is updated multiple times. However, it is not sensitive to the order in which thorns are activated if all thorns are specified in a single line. This inconsistency should be removed, and the order should not matter in either case.

Attachments (0)

Change History (7)

comment:1 Changed 6 years ago by Frank Löffler

Milestone: Cactus_4.1.0Cactus_4.2.0

Would be nice, but not for the next release anymore.

comment:2 Changed 6 years ago by Frank Löffler

Milestone: Cactus_4.2.0

comment:3 Changed 6 years ago by Frank Löffler

Isn't this now already order-independent?

comment:4 Changed 6 years ago by Roland Haas

If you have several ActiveThorns lines in your parfile then the order matters. Ie.

ActiveTHorns = "CarpetLib"
Carpet::max_refinement_levels = 1
ActiveTorns = "Carpet"

fails as well as

ActiveTorns = "Carpet"
ActiveTHorns = "CarpetLib"

while

ActiveTorns = "Carpet
               CarpetLib"

is fine.

comment:5 Changed 6 years ago by Frank Löffler

I know that this used to be the case, but Steve told me that piraha actually combines all ActiveThorns requests into one. What I don't know right now is whether that is in trunk already, or still in its own branch. Steve?

comment:6 Changed 6 years ago by Steven R. Brandt

As Frank said. Since Piraha, the order should no longer matter. Piraha combines all the ActiveThorn declarations into one before passing it through to Cactus.

comment:7 Changed 6 years ago by Erik Schnetter

The Cactus documentation says:

\item{} The parameter file is read \emph{sequentially} from top to bottom,
        this means that if you set the value of a parameter twice in
        the parameter file, the second value will be used. (This is
        why the \texttt{ActiveThorns} parameter is always first in the file).

Please update this.

There are also many instances in the users' guide which speak of ActiveThorns as "the first parameter being set". If we allow this to be set multiple times, and if this is commonly used, then this should be mentioned as well.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The ticket will remain with no owner.
Next status will be 'review'.
as The resolution will be set.
to The owner will be changed from (none) to the specified user.
Next status will be 'confirmed'.
The owner will be changed from (none) to anonymous.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.