NaNChecker should not reduce in local mode

Comments (10)

Frank Löffler
- removed comment
I use it for simulations on one MPI processor but multiple levels and components there. What is the symptom I should see in that case? False positives?
- 2012-03-03T09:41:01+00:00
Erik Schnetter reporter
- removed comment
In your case (same number of components on each process), the bit mask seems to be reset for each component.
- 2012-03-03T09:52:22+00:00
Frank Löffler
- removed comment
That would mean potentially missing NaNs, right?
- 2012-03-03T10:25:13+00:00
Erik Schnetter reporter
- removed comment
If there are nans, the NaNChecker will find some nans. However, the bit mask in the output nanmask may be inconsistent.
- 2012-03-03T13:12:22+00:00
Roland Haas
- removed comment
The attached patch splits NaNCheckers operation into a local search routine followed by a per-level reduction. It does not use ENTER_LEVEL_MODE to not rely on Carpet's code (ie. to compile without Carpet present). Note that NaNChecker does not trigger the warning in CarpetReduce since it uses reducelocalscalar so does not reduce a grid function (it seems to end up in ReduceArrays inside of CarpetReduce). I attach a test for NaNChecker (using PUGH, which is likely fragily since it relies on IEEE floating point math to create NaNs on the grid).
- 2012-03-20T11:16:32+00:00
Roland Haas
- changed status to open
- removed comment
- 2012-03-20T11:16:39+00:00
Erik Schnetter reporter
- removed comment
Please apply.
- 2012-03-20T12:17:08+00:00
Roland Haas
- removed comment
It's in cacutscode, I cannot apply it myself.
- 2012-03-20T12:34:55+00:00
Roland Haas
- changed status to resolved
- removed comment
I knew there was something that I had outstanding to commit :-) Though I had thought it was the change to IOJpeg. Applied.
- 2012-03-26T22:18:24+00:00
Roland Haas
- edited description
- changed status to closed
- 2019-02-21T19:55:56+00:00
Log in to comment