McLachlan dissipation should be disabled by default

Comments (14)

1. 

   Erik Schnetter

   • removed comment

   What about modifying the way in which McLachlan iterates over variables? One calculation per variable should be easy to realise:

   dissCalcs = Table[ { Name -> BSSN <> "_Dissipation_" <> ToString[var /. {Tensor[n_,] -> n}], Schedule -> {"IN " <> BSSN <> "_evolCalcGroup " <> "AFTER (" <> BSSN <> "_RHS1 " <> BSSN <> "_RHS2)"}, ConditionalOnKeyword -> {"apply_dissipation", "always"}, Where -> InteriorNoSync, Shorthands -> {epsdiss[ua]}, Equations -> { epsdiss[ua] -> EpsDiss, dot[var] -> dot[var] + epsdiss[ux] PDdiss[var,lx] } }, {var, {phi, gt[la,lb], Xt[ui], trK, At[la,lb], alpha, A, beta[ua], B[ua]}} ];

   Otherwise, this is okay to change.

   Do you then also want to change the default epsdiss value to be the same as for thorn Dissipation?

   • 2012-03-15T07:25:47+00:00
2. 

   Erik Schnetter

   • changed status to open
   • removed comment

   • 2012-05-05T09:21:54+00:00
3. 

   Erik Schnetter

   • changed status to open
   • removed comment

   • 2012-05-05T09:22:03+00:00
4. 

   Erik Schnetter

   • changed milestone to ET_2012_05
   • removed comment

   • 2012-05-07T21:29:52+00:00
5. 

   Roland Haas

   • changed status to open
   • assigned issue to
   • removed comment

   Erik: would you mind to apply this? Ian is busy and I am not sure what precisely should be applied (ie just the parameter change or also the change in Kranc code).

   • 2012-05-16T12:51:21+00:00
6. 

   Erik Schnetter

   • removed comment

   Only the default value of the parameter should be changed.

   I am trying this change (only changing the default for apply_dissipation from "always" to "never"). For some reason, this breaks the test cases

   KerrSchild-rotating-180 (from RotatingSymmetry180) KerrSchild-rotating-90 (from RotatingSymmetry90) which don't set any of McLachlan's dissipation parameters, and which should therefore currently not be applying dissipation. The differences look significant.

   I don't understand why there are differences in these test cases, and am therefore not applying this patch at the moment.

   • 2012-05-17T17:40:21+00:00
7. 

   Frank Löffler

   • changed milestone to ET_2012_11
   • removed comment

   • 2012-05-21T10:26:32+00:00
8. 

   Erik Schnetter

   • changed status to resolved
   • removed comment

   The current version of McLachlan already has the dissipation set to zero by default.

   • 2012-10-22T14:44:49+00:00
9. 

   Erik Schnetter

   • changed status to open
   • removed comment

   This ticket is actually about the keyword apply_dissipation, not about the value of the dissipation parameter. Re-opening.

   • 2012-10-22T15:19:07+00:00
10. 

    Peter Diener

    • removed comment

    I have just tried to set the default for apply_dissipation to "never" and I don't see any issues with the test cases mentioned above.

    • 2012-10-23T10:03:50+00:00
11. 

    Erik Schnetter

    • changed status to open
    • removed comment

    Good! Maybe it is a weirdness for my machine only.

    Could you commit this?

    • 2012-10-23T10:10:45+00:00
12. 

    Erik Schnetter

    • changed status to open
    • removed comment

    • 2012-10-23T10:10:51+00:00
13. 

    Peter Diener

    • changed status to resolved
    • removed comment

    Committed.

    • 2012-10-23T10:59:56+00:00
14. 

    Roland Haas

    • edited description
    • changed status to closed

    • 2019-02-21T19:55:51+00:00
15. Log in to comment