- changed status to resolved
- removed comment
Add thornlist default to defs.local.ini.simple
Issue #82
closed
If a user doesn't specify a thornlist, they only the Cactus flesh is built, but SimFactory doesn't warn that this is the case. I think that if you don't specify a thornlist, it should be an error/warning.
Additionally, I think it would be helpful to add something like
[default] thornlist = manifest/einsteintoolkit.th
to defs.local.ini.simple to make things easier for new users.
Keyword:
Comments (2)
-
-
- edited description
- changed status to closed
- Log in to comment
- Assignee
-
anonymous
- Type
- Priority
- Status
- closed
- Component
- SimFactory
- Milestone
- –
- Version
- –
- Votes
- 0
- Watchers
- 0
The thornlist has been added to defs.local.ini.simple in revision 1021.
In revision 1021, omitting the thornlist leads to the error:
"Error: machine macbook is missing a required key: thornlist".
It would be better if this was before the configuration step, but not critical. However, suggesting that the *machine* is the place for the thornlist is bad. Instead, I have detected the missing thornlist condition and added the error message:
Error: No thornlist supplied. Use --thornlist <thornlist> on the command line or set thornlist = <thornlist> in the [default] section of defs.local.ini.
in revision 1022.