close all HDF5 objects in EOS Omni table reader

Comments (7)

1. 

   Roland Haas reporter

   • changed status to open
   • removed comment

   • 2012-05-11T10:16:16+00:00
2. 

   Frank Löffler

   • removed comment

   This patch also declares a function static and removes another function declaration. Is this intentional and related to the problem? It doesn't seem to be.

   • 2012-05-16T21:28:51+00:00
3. 

   Roland Haas reporter

   • removed comment

   It's intentional. It does not relate to the problem. It should be done though, since pushing a function with the rather common name "file_is_readable" into the global namespace seems dangerous. It removes a function declaration that Cactus now provides on its own. You are certainly correct though. Lines 133 and 134 are the only changes that are actually mentioned in the ticket title.

   • 2012-05-16T21:46:01+00:00
4. 

   Frank Löffler

   • changed status to open
   • removed comment

   Was just checking - ok to commit the whole patch, thanks!

   • 2012-05-16T22:32:50+00:00
5. 

   Roland Haas reporter

   • removed comment

   Hello Frank. Sorry to sound so grumpy. That was not intended. I had written the comment in the two minutes before leaving for a talk. I'll wait until after the release with since it is not critical in any way.

   • 2012-05-16T22:42:32+00:00
6. 

   Roland Haas reporter

   • changed status to resolved
   • removed comment

   Sorry. I had confused #821 and this one. I applied this patch as rev 59 since it is so trivial. Thanks for the review.

   • 2012-05-16T23:17:16+00:00
7. 

   Roland Haas reporter

   • edited description
   • changed status to closed

   • 2019-02-21T20:20:45+00:00
8. Log in to comment