ExternalLibraries/zlib gives bad error message if "patch" is not available

Comments (10)

1. 

   Erik Schnetter

   • removed comment

   I suggest using ${PATCH?}.

   • 2012-04-26T09:40:36+00:00
2. 

   Erik Schnetter

   • changed status to open
   • removed comment

   • 2012-08-10T11:38:02+00:00
3. 

   Erik Schnetter

   • changed status to open
   • removed comment

   • 2012-08-10T11:38:07+00:00
4. 

   Roland Haas

   • removed comment

   The same ${PATCH} vs ${PATCH?} issue exists in eg. LORENE as well as for ${TAR} (most likely in all ExternalLibraries). Cactus' configure tests for PATCH and TAR. Would the build system abort with a useful error message if the zlib had declared PATCH (and TAR) in its OPTIONS (that would be rather neat)?

   • 2012-08-11T16:19:01+00:00
5. 

   Ian Hinder reporter

   • removed comment

   Why don't we just use

   set -u

   in all the configuration scripts? This gives a fatal runtime error if a variable is used that has not been assigned a value. It is mostly equivalent to using ${var?} syntax for all variables.

   • 2012-08-12T03:20:09+00:00
6. 

   Erik Schnetter

   • removed comment

   "set -u" is probably too rigorous, because many people will leave e.g. HDF5_LIB_DIRS undefined if they want it to be empty.

   We could set PATCH, TAR, etc. to "false" in configure. This way they will always be defined, and will return an error when they are used.

   • 2012-08-12T09:16:57+00:00
7. 

   Ian Hinder reporter

   • removed comment

   If it is valid for a variable to be undefined, then we can test explicitly for that in the configure script and reset it to empty if it is not defined. I think it is better to have the configure scripts robust.

   • 2012-08-12T12:24:12+00:00
8. 

   Erik Schnetter

   • removed comment

   I expect that most configuration variables are optional, and thus explicitly setting them to empty if they are unset would be inconvenient.

   • 2012-08-12T17:18:43+00:00
9. 

   Erik Schnetter

   • changed status to resolved
   • removed comment

   Using ${PATCH?} and ${TAR?} in all configuration scripts.

   • 2012-09-16T18:07:57+00:00
10. 

    Roland Haas

    • edited description
    • changed status to closed

    • 2019-02-21T20:20:32+00:00
11. Log in to comment