1. Einstein Toolkit Avatar Einstein Toolkit
  2. Einstein Toolkit
  3. tickets
  4. Issues

Improve error reporting in Multipole

Issue #864 open
Ian Hinder created an issue

When Multipole encounters an interpolation error, the error output from the interpolator consists of thousands of lines each listing the points that failed. This is too much information to process. It is also not clear that the error came from Multipole.

  1. This output should be limited;
  2. The error should be prefixed with "Multipole" so the user knows which thorn was responsible for calling the interpolator (maybe the new CCTK_ScheduleQueryCurrentFunction from #817 could be used for this);
  3. Multipole should contain a check in CCTK_PARAMCHECK that the extraction radii are not outside the Cactus base grid.

Keyword:

Comments (2)

  1. Roland Haas

    One can take inspiration from what AHFinderDirect does: https://bitbucket.org/einsteintoolkit/einsteinanalysis/src/d4f9f9d8a4b2a2670b0b07a9ab8de35baa73a518/AHFinderDirect/src/gr/expansion.cc#lines-712

        // set a dummy value for the key "suppress_warnings"
    // to tell CCTK_InterpGridArrays() not to print warning messages
    // for points outside the grid
    status = Util_TableSetInt(gi.param_table_handle,
                  0,
                  "suppress_warnings");

    the check the return value https://bitbucket.org/einsteintoolkit/einsteinanalysis/src/d4f9f9d8a4b2a2670b0b07a9ab8de35baa73a518/AHFinderDirect/src/gr/expansion.cc#lines-881

    //
// ***** handle any interpolation errors *****
//
if (status == CCTK_ERROR_INTERP_POINT_OUTSIDE)

    ‌

  3. Log in to comment
Assignee
–
Type
enhancement
Priority
minor
Status
open
Component
EinsteinToolkit thorn
Milestone
–
Version
–
Votes
0
Watchers
0
Jira Software: the preferred issue tracker for Bitbucket. Join the team!