Modify

Opened 7 years ago

Last modified 7 years ago

#868 reopened enhancement

Write Formaline tarballs in the background

Reported by: Erik Schnetter Owned by:
Priority: minor Milestone:
Component: EinsteinToolkit thorn Version:
Keywords: Cc:

Description

Write the Formaline tarballs in the background (using fork()) to
elminiate the wait.

Attachments (1)

formaline-background.patch (1.7 KB) - added by Erik Schnetter 7 years ago.

Download all attachments as: .zip

Change History (7)

Changed 7 years ago by Erik Schnetter

Attachment: formaline-background.patch added

comment:1 Changed 7 years ago by Erik Schnetter

Status: newreview

comment:2 Changed 7 years ago by Roland Haas

The patch looks ok with maybe the single exception that it does a VInfo from within the fork()ed child which may (or may not) involve transporting stdout data to the MPI root process? The suggested method of using a pthread might be safer in case there are still MPI implementations out there that do not like fork(). Maybe one could add a parameter to disable parallel writing. Otherwise fine to apply.

comment:3 Changed 7 years ago by Erik Schnetter

I will apply this after the release, possibly using pthreads instead of fork.

comment:4 Changed 7 years ago by Erik Schnetter

Status: reviewreviewed_ok

comment:5 Changed 7 years ago by Roland Haas

I'll link to #914 so that we don't forget.

comment:6 Changed 7 years ago by Erik Schnetter

Status: reviewed_okreopened

I retract this patch, since using fork() with MPI is in general not safe. An implementation on pthreads should be safe, however.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as reopened The ticket will remain with no owner.
Next status will be 'review'.
as The resolution will be set.
to The owner will be changed from (none) to the specified user.
The owner will be changed from (none) to anonymous.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.