- changed status to open
- removed comment
bashism in ThornDoc
Issue #901
closed
ThornDoc uses '==' within 'test' to test for something being equal. However, for shell scripts this should be '='. This works in bash, since it also accepts '==', but it does not work for /bin/sh by default, which is what ThornDoc claims to be a script for. The effect is that 'make THORN-ThornDoc' prints a lot of warnings.
The attached patch fixes this by replacing '==' with '='.
Keyword:
Comments (5)
-
reporter
-
- changed status to open
- removed comment
Please apply. Please check ArrangementDoc for similar issues.
-
- removed comment
Would it be safer to change these scripts to require bash?
-
reporter
- changed status to resolved
- removed comment
I applied the same patch to ArrangementDoc, thanks for the hint. We could resolve it by letting the scripts use bash instead, but I don't think we should unless there is some reason for using bash features.
-
- edited description
- changed status to closed
- Log in to comment
- Assignee
- –
- Type
- Priority
- Status
- closed
- Component
- Cactus
- Milestone
- ET_2012_05
- Version
- development version
- Votes
- 0
- Watchers
- 0
