Rename configure scripts to "configure.sh"

Issue #954 closed

Erik Schnetter created an issue 2012-06-11

Each thorn in ExternalLibraries has a script that configures it. For historic reasons these scripts all have different names. I propose to rename them all to "configure.*", where the suffix denotes the language (e.g. sh or pl).

Keyword:

Comments (7)

Erik Schnetter reporter
- changed status to open
- removed comment
- 2012-06-11T22:42:27+00:00
Frank Löffler
- removed comment
Since the name of the configure script has to be specified in the ccl files anyway this shouldn't be more than a cosmetic change, and a welcome one. Please apply.
- 2012-06-12T11:06:08+00:00
Erik Schnetter reporter
- changed status to open
- removed comment
- 2012-06-12T11:58:06+00:00
Erik Schnetter reporter
- changed status to resolved
- removed comment
Done.
- 2012-06-12T13:29:27+00:00
Roland Haas
- removed comment
Now that all these scripts (actually it would be nicest if one could use the SCRIPT entry of configuration.ccl) are named configure.sh, would it make sense to add them to the make dependencies? So that the library is rebuild when this file changes? I have no idea how hard to implement this would be.
- 2012-07-01T20:46:39+00:00
Erik Schnetter reporter
- removed comment
Can you open a ticket for this, and add this discussion?

The script itself already checks a few conditions to find out whether the library needs rebuilding. One way would be to add a new DEPENDENCIES output to the script, which the flesh then processes when it decides whether to run the CST.
- 2012-07-02T08:00:17+00:00
Roland Haas
- edited description
- changed status to closed
- 2019-02-21T20:14:19+00:00
Log in to comment

Assignee: –

Type: enhancement

Priority: minor

Status: closed

Component: EinsteinToolkit thorn

Milestone: –

Version: –

Votes: 0

Watchers: 0